AGENT-1579: Agent-based installer - add static networking support for ISO_NO_REGISTRY mode - #1940
Open
bfournie wants to merge 4 commits into
Open
Conversation
Add TUI automation to configure static IPs, hostnames, and DNS via nmtui for agent-based ISO_NO_REGISTRY installations. Creates a NEW NetworkManager connection (rather than editing the existing DHCP one) to ensure --copy-network is triggered by coreos-installer, preserving the static config across reboots. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
This appears to work well, removing the WIP The install was successfully And can log in via the static IP to all of the nodes |
bfournie
changed the title
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
andfasano
reviewed
Aug 4, 2026
bfournie
changed the title
Contributor
Author
|
/jira refresh |
- Activate the static networking scenario via the existing AGENT_TEST_CASES
mechanism ('static_ip') instead of a dedicated config var, matching the
'bad_dns' approach.
- Add an end-of-installation verification step that ssh's to each node at its
assigned static IP and confirms the hostname, so the scenario is a complete
test (configure via TUI, then verify).
- Rename automate-no-registry-agent-tui-static.sh to test-static-ip.sh and add
a header describing what the script does.
- Centralize static IP assignment in staticIPForNode (agent/common.sh) and
reuse it for rendezvous IP, configuration and verification.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
verify_static_networking ran a single ssh attempt immediately after the UI reported the console URL as available, but at that point the nodes are still rebooting and finalizing (applying the static IP via coreos-installer --copy-network), so the static IP is not yet reachable and the check failed even though the node came up moments later. Retry the ssh check (up to ~20 min) until the node is reachable at its static IP before failing. Also drop the redundant `timeout 60` wrapper since the SSH command already sets ConnectTimeout. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Nodes are reachable on the first attempt once the console URL is available, so the ~20 min retry budget was excessive. Reduce to ~5 min (10 attempts at 30s), which still leaves headroom for a slightly slower node. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Author
|
Confirmed on compact installation |
|
@bfournie: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add TUI automation to configure static IPs and hostnames via nmtui for agent-based ISO_NO_REGISTRY installations. Creates a NEW NetworkManager connection (rather than editing the existing DHCP one) to ensure
--copy-networkis triggered by coreos-installer, preserving the static config across reboots.See openshift/assisted-installer-agent#1374